Update logstash docker to use ubuntu 20.04 base image #13442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbavey
force-pushed
the
docker_ubuntu
branch
from
57c2520
to
a8c0ebc
Compare
|
This passes CI on |
This was referenced Nov 25, 2021
robbavey
force-pushed
the
docker_ubuntu
branch
from
a8c0ebc
to
02afc19
Compare
|
Fixes #13438 |
jsvd
reviewed
Dec 7, 2021
There was a problem hiding this comment.
I am getting locale warnings when starting that I don't recall seeing in the centos image.
❯ docker run docker.elastic.co/logstash/logstash-full:8.1.0-SNAPSHOT
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
/bin/bash: warning: setlocale: LC_ALL: cannot change locale (en_US.UTF-8)
docker/templates/Dockerfile.j2
Outdated
Comment on lines
29
to
32
| RUN for iter in {1..10}; do \ | ||
| {% if image_flavor != 'ubi8' -%} | ||
| export DEBIAN_FRONTEND=noninteractive && \ | ||
| {% endif -%} |
There was a problem hiding this comment.
I was tempted to move this export to outside of the run loop, but that would add an extra RUN layer, so let's just keep it as is 👍
|
Fixed Tests pass across distributions and architectures: https://logstash-ci.elastic.co/job/elastic+logstash+master+multijob-docker-acceptance/198/ |
robbavey
added a commit
to robbavey/logstash
that referenced
this pull request
Dec 9, 2021
…0.04 base image Backport elastic#13442 to 8.0 branch. Original message: * Update logstash docker to use ubuntu 20.04 base image * Correctly set locale for ubuntu docker image * tiny typo fix: ubunto -> ubuntu Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
5 tasks
robbavey
added a commit
that referenced
this pull request
Dec 11, 2021
…se image (#13490) Backport #13442 to 8.0 branch. Original message: * Update logstash docker to use ubuntu 20.04 base image * Correctly set locale for ubuntu docker image * tiny typo fix: ubunto -> ubuntu Co-authored-by: João Duarte <jsvd@users.noreply.github.com> Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
robbavey
added a commit
to robbavey/logstash
that referenced
this pull request
Dec 16, 2021
…20.04 base image Backport elastic#13442 to 7.17 branch. Original message: * Update logstash docker to use ubuntu 20.04 base image * Correctly set locale for ubuntu docker image * tiny typo fix: ubunto -> ubuntu Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
robbavey
added a commit
that referenced
this pull request
Dec 16, 2021
…ase image (#13529) Backport #13442 to 7.17 branch. Original message: * Update logstash docker to use ubuntu 20.04 base image * Correctly set locale for ubuntu docker image * tiny typo fix: ubunto -> ubuntu Co-authored-by: João Duarte <jsvd@users.noreply.github.com> Co-authored-by: João Duarte <jsvd@users.noreply.github.com>
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the base image of the logstash
fullandossdocker images to use ubuntu 20.04 as the base image.The
ubi8image remains unchanged